Improve error reporting when non mandatory options are misconfigured#1294
Closed
jayychoi wants to merge 1 commit intospring-projects:mainfrom
Closed
Improve error reporting when non mandatory options are misconfigured#1294jayychoi wants to merge 1 commit intospring-projects:mainfrom
jayychoi wants to merge 1 commit intospring-projects:mainfrom
Conversation
Resolves spring-projects#1245 Signed-off-by: Jay Choi <jayyoungchoi22@gmail.com>
Contributor
|
This PR was valid based on my comment here: #1245 (comment). However, as explained in #1245 (comment), things have changed since then and we now accept non-mandatory options without default values. Therefore, this PR is not up-to-date anymore. I am closing it. Thank you for your contribution anyway 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error reporting for optional options that are misconfigured.
Fail fast for optional options without default value:
CommandFactoryBeannow validates that optional options must have a default value. If an optional option is declared without a default value, the application fails at startup with a clear error message instead of logging a warning at runtime.Option without value already handled: This is already handled by
DefaultCommandParsersince commit 78d1a47, which throws anIllegalArgumentExceptionwhen parsing such input.Changes
CommandFactoryBean: Added validation to reject optional options without default values at command registration timeCommandFactoryBeanTests: Added unit tests for the new validation logicResolves #1245